Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change check_robustness dataset #361

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Change check_robustness dataset #361

merged 1 commit into from
Dec 19, 2020

Conversation

Opdoop
Copy link
Contributor

@Opdoop Opdoop commented Dec 3, 2020

As Adversarial training using training data, although here has a random sample, it's more reasonable to use eval data to check robustness.

@qiyanjun
Copy link
Member

qiyanjun commented Dec 3, 2020

@Opdoop let me check the doc error.

@qiyanjun
Copy link
Member

qiyanjun commented Dec 5, 2020

@Opdoop please rebase

As Adversarial training using training data, although here has a random sample, it's more reasonable to use eval data to check robustness.
@Opdoop
Copy link
Contributor Author

Opdoop commented Dec 6, 2020

@qiyanjun Rebased

Copy link
Collaborator

@jxmorris12 jxmorris12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that evaluating adversarial robustness using the evaluation dataset is a reasonable default!

@jxmorris12 jxmorris12 merged commit a029964 into QData:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants